Skip to content

Commit

Permalink
ARM: fix lcd power build failure in collie_defconfig
Browse files Browse the repository at this point in the history
Commit 086ada5

  "FB: sa1100: remove global sa1100fb_.*_power function pointers"

got rid of all instances but one in locomolcd.c -- which was
conditional on CONFIG_SA1100_COLLIE.  The associated .power
field which replaces the global is populated in mach-sa1100/collie.c
so move the assignment there, but make it conditional on the
locomolcd support, so use CONFIG_BACKLIGHT_LOCOMO in that file.

Cc: arm@kernel.org
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
  • Loading branch information
Paul Gortmaker authored and Olof Johansson committed Apr 3, 2012
1 parent ee5324e commit beca98c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
4 changes: 4 additions & 0 deletions arch/arm/mach-sa1100/collie.c
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ static struct sa1100fb_mach_info collie_lcd_info = {

.lccr0 = LCCR0_Color | LCCR0_Sngl | LCCR0_Act,
.lccr3 = LCCR3_OutEnH | LCCR3_PixRsEdg | LCCR3_ACBsDiv(2),

#ifdef CONFIG_BACKLIGHT_LOCOMO
.lcd_power = locomolcd_power
#endif
};

static void __init collie_init(void)
Expand Down
3 changes: 2 additions & 1 deletion arch/arm/mach-sa1100/include/mach/collie.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* arch/arm/mach-sa1100/include/mach/collie.h
*
* This file contains the hardware specific definitions for Assabet
* This file contains the hardware specific definitions for Collie
* Only include this file from SA1100-specific files.
*
* ChangeLog:
Expand All @@ -13,6 +13,7 @@
#ifndef __ASM_ARCH_COLLIE_H
#define __ASM_ARCH_COLLIE_H

extern void locomolcd_power(int on);

#define COLLIE_SCOOP_GPIO_BASE (GPIO_MAX + 1)
#define COLLIE_GPIO_CHARGE_ON (COLLIE_SCOOP_GPIO_BASE + 0)
Expand Down
9 changes: 1 addition & 8 deletions drivers/video/backlight/locomolcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,7 @@ static struct locomo_driver poodle_lcd_driver = {

static int __init locomolcd_init(void)
{
int ret = locomo_driver_register(&poodle_lcd_driver);
if (ret)
return ret;

#ifdef CONFIG_SA1100_COLLIE
sa1100fb_lcd_power = locomolcd_power;
#endif
return 0;
return locomo_driver_register(&poodle_lcd_driver);
}

static void __exit locomolcd_exit(void)
Expand Down

0 comments on commit beca98c

Please sign in to comment.