Skip to content

Commit

Permalink
drivers/char: use LIST_HEAD instead of LIST_HEAD_INIT
Browse files Browse the repository at this point in the history
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.

Signed-off-by: Denis Cheng <crquan@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Denis Cheng authored and Linus Torvalds committed Feb 6, 2008
1 parent a18b630 commit bed9759
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/char/hvc_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct hvc_struct {
};

/* dynamic list of hvc_struct instances */
static struct list_head hvc_structs = LIST_HEAD_INIT(hvc_structs);
static LIST_HEAD(hvc_structs);

/*
* Protect the list of hvc_struct instances from inserts and removals during
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/hvcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ struct hvcs_struct {
/* Required to back map a kref to its containing object */
#define from_kref(k) container_of(k, struct hvcs_struct, kref)

static struct list_head hvcs_structs = LIST_HEAD_INIT(hvcs_structs);
static LIST_HEAD(hvcs_structs);
static DEFINE_SPINLOCK(hvcs_structs_lock);

static void hvcs_unthrottle(struct tty_struct *tty);
Expand Down
4 changes: 2 additions & 2 deletions drivers/char/ipmi/ipmi_msghandler.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,12 +365,12 @@ static struct device_driver ipmidriver = {
};
static DEFINE_MUTEX(ipmidriver_mutex);

static struct list_head ipmi_interfaces = LIST_HEAD_INIT(ipmi_interfaces);
static LIST_HEAD(ipmi_interfaces);
static DEFINE_MUTEX(ipmi_interfaces_mutex);

/* List of watchers that want to know when smi's are added and
deleted. */
static struct list_head smi_watchers = LIST_HEAD_INIT(smi_watchers);
static LIST_HEAD(smi_watchers);
static DEFINE_MUTEX(smi_watchers_mutex);


Expand Down

0 comments on commit bed9759

Please sign in to comment.