Skip to content

Commit

Permalink
ide-cd: use ide_end_rq() also for failed non-fs requests
Browse files Browse the repository at this point in the history
Use ide_end_rq() also for failed non-fs requests on completion
of REQUEST SENSE requests + use blk_rq_bytes() while at it.

Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Mar 31, 2009
1 parent 116e690 commit bf12a9c
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions drivers/ide/ide-cd.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,18 +265,10 @@ static void cdrom_end_request(ide_drive_t *drive, int uptodate)
failed->sense_len = rq->sense_len;
}
cdrom_analyze_sense_data(drive, failed, sense);
/*
* now end the failed request
*/
if (blk_fs_request(failed)) {
if (ide_end_rq(drive, failed, -EIO,
failed->hard_nr_sectors << 9))
BUG();
} else {
if (blk_end_request(failed, -EIO,
failed->data_len))
BUG();
}

if (ide_end_rq(drive, failed, -EIO,
blk_rq_bytes(failed)))
BUG();
} else
cdrom_analyze_sense_data(drive, NULL, sense);
}
Expand Down

0 comments on commit bf12a9c

Please sign in to comment.