Skip to content

Commit

Permalink
extcon: arizona: Use MICDET for final microphone identification
Browse files Browse the repository at this point in the history
When using HPDET to identify the accessory still run MICDET before we
report a microphone in order to ensure that the accessory identified is
compatible with the MICDET detection ranges after having confirmed that
the device is not using a headphone.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Mark Brown committed Feb 11, 2013
1 parent c37b387 commit bf14ee5
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/extcon/extcon-arizona.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ struct arizona_extcon_info {
struct delayed_work hpdet_work;

bool hpdet_active;
bool hpdet_done;

int num_hpdet_res;
unsigned int hpdet_res[3];
Expand Down Expand Up @@ -394,7 +395,6 @@ static int arizona_hpdet_do_id(struct arizona_extcon_info *info, int *reading)
{
struct arizona *arizona = info->arizona;
int id_gpio = arizona->pdata.hpdet_id_gpio;
int ret;

/*
* If we're using HPDET for accessory identification we need
Expand Down Expand Up @@ -463,13 +463,7 @@ static int arizona_hpdet_do_id(struct arizona_extcon_info *info, int *reading)
(id_gpio && info->hpdet_res[2] > 10)) {
dev_dbg(arizona->dev, "Detected mic\n");
info->mic = true;
ret = extcon_set_cable_state_(&info->edev,
ARIZONA_CABLE_MICROPHONE,
true);
if (ret != 0) {
dev_err(arizona->dev,
"Failed to report mic: %d\n", ret);
}
info->detecting = true;
} else {
dev_dbg(arizona->dev, "Detected headphone\n");
}
Expand Down Expand Up @@ -586,6 +580,8 @@ static irqreturn_t arizona_hpdet_irq(int irq, void *data)
info->hpdet_active = false;
}

info->hpdet_done = true;

out:
mutex_unlock(&info->lock);

Expand All @@ -597,6 +593,9 @@ static void arizona_identify_headphone(struct arizona_extcon_info *info)
struct arizona *arizona = info->arizona;
int ret;

if (info->hpdet_done)
return;

dev_dbg(arizona->dev, "Starting HPDET\n");

/* Make sure we keep the device enabled during the measurement */
Expand Down Expand Up @@ -923,6 +922,7 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
for (i = 0; i < ARRAY_SIZE(info->hpdet_res); i++)
info->hpdet_res[i] = 0;
info->mic = false;
info->hpdet_done = false;

for (i = 0; i < ARIZONA_NUM_BUTTONS; i++)
input_report_key(info->input,
Expand Down

0 comments on commit bf14ee5

Please sign in to comment.