Skip to content

Commit

Permalink
ktest: Fix make_min_config test when build fails
Browse files Browse the repository at this point in the history
The make_min_config does not take into account when the build fails,
resulting in a invalid MIN_CONFIG .config file. When the build fails,
it is ignored and the boot test is executed, using the previous built
kernel. The configs that should be tested are not tested and they may
be added or removed depending on the result of the last kernel that
succeeded to be built.

If the build fails, mark the current config as a failure and the
configs that were disabled may still be needed.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Feb 27, 2012
1 parent be405f9 commit bf1c95a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -3244,9 +3244,11 @@ sub make_min_config {
$in_bisect = 1;

my $failed = 0;
build "oldconfig";
start_monitor_and_boot or $failed = 1;
end_monitor;
build "oldconfig" or $failed = 1;
if (!$failed) {
start_monitor_and_boot or $failed = 1;
end_monitor;
}

$in_bisect = 0;

Expand Down

0 comments on commit bf1c95a

Please sign in to comment.