Skip to content

Commit

Permalink
staging: comedi: addi-data: remove addi_amcc_s5933.h
Browse files Browse the repository at this point in the history
Now that the PCI bus walking has been removed from the addi-data
drivers, the only differenced between addi_amcc_s9533.h and the
standard comedi amcc_s5933.h is the additional defines for the
apci3120 "ADDON RELATED ADDITIONS". Move those defines to
hwdrv_apci3120.c.

Modify all the addi-data drivers to then include the standard
comedi amcc_s5933.h header and delete the duplicate in addi-data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Nov 1, 2012
1 parent ae0e3b8 commit bf36f01
Show file tree
Hide file tree
Showing 19 changed files with 47 additions and 210 deletions.
193 changes: 0 additions & 193 deletions drivers/staging/comedi/drivers/addi-data/addi_amcc_s5933.h

This file was deleted.

1 change: 0 additions & 1 deletion drivers/staging/comedi/drivers/addi-data/addi_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include <linux/kmod.h>
#include <linux/uaccess.h>
#include "../../comedidev.h"
#include "addi_amcc_s5933.h"

#define ERROR -1
#define SUCCESS 1
Expand Down
31 changes: 31 additions & 0 deletions drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,37 @@ You should also find the complete GPL in the COPYING file accompanying this sour
+----------+-----------+------------------------------------------------+
*/

/*
* ADDON RELATED ADDITIONS
*/
/* Constant */
#define APCI3120_ENABLE_TRANSFER_ADD_ON_LOW 0x00
#define APCI3120_ENABLE_TRANSFER_ADD_ON_HIGH 0x1200
#define APCI3120_A2P_FIFO_MANAGEMENT 0x04000400L
#define APCI3120_AMWEN_ENABLE 0x02
#define APCI3120_A2P_FIFO_WRITE_ENABLE 0x01
#define APCI3120_FIFO_ADVANCE_ON_BYTE_2 0x20000000L
#define APCI3120_ENABLE_WRITE_TC_INT 0x00004000L
#define APCI3120_CLEAR_WRITE_TC_INT 0x00040000L
#define APCI3120_DISABLE_AMWEN_AND_A2P_FIFO_WRITE 0x0
#define APCI3120_DISABLE_BUS_MASTER_ADD_ON 0x0
#define APCI3120_DISABLE_BUS_MASTER_PCI 0x0

/* ADD_ON ::: this needed since apci supports 16 bit interface to add on */
#define APCI3120_ADD_ON_AGCSTS_LOW 0x3C
#define APCI3120_ADD_ON_AGCSTS_HIGH (APCI3120_ADD_ON_AGCSTS_LOW + 2)
#define APCI3120_ADD_ON_MWAR_LOW 0x24
#define APCI3120_ADD_ON_MWAR_HIGH (APCI3120_ADD_ON_MWAR_LOW + 2)
#define APCI3120_ADD_ON_MWTC_LOW 0x058
#define APCI3120_ADD_ON_MWTC_HIGH (APCI3120_ADD_ON_MWTC_LOW + 2)

/* AMCC */
#define APCI3120_AMCC_OP_MCSR 0x3C
#define APCI3120_AMCC_OP_REG_INTCSR 0x38

/* for transfer count enable bit */
#define AGCSTS_TC_ENABLE 0x10000000

/* used for test on mixture of BIP/UNI ranges */
#define APCI3120_BIPOLAR_RANGES 4

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_035.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define ADDIDATA_WATCHDOG 2 /* Or shold it be something else */

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_1032.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci1032.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_1500.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci1500.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_1516.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci1516.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_1564.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci1564.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_16xx.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci16xx.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_1710.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

static void fpu_begin(void)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_2016.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci2016.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_2032.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci2032.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_2200.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci2200.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_3001.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci3120.c"
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_3120.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#define CONFIG_APCI_3120 1

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_3200.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

static void fpu_begin(void)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_3300.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

static void fpu_begin(void)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/addi_apci_3501.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include "../comedidev.h"
#include "comedi_fc.h"
#include "amcc_s5933.h"

#include "addi-data/addi_common.h"
#include "addi-data/addi_amcc_s5933.h"

#include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_apci3501.c"
Expand Down
Loading

0 comments on commit bf36f01

Please sign in to comment.