Skip to content

Commit

Permalink
[PATCH] powerpc numa: Minor debugging code changes
Browse files Browse the repository at this point in the history
Add debug statement for map_cpu_to_node; it's useful for cpu hotplug.

Clarify debug statement about not finding the numa reference points
property.

Don't print a meaningless associativity depth (-1) on non-numa systems.

Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Nathan Lynch authored and Paul Mackerras committed Mar 22, 2006
1 parent c08888c commit bf4b85b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions arch/powerpc/mm/numa.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ static inline void map_cpu_to_node(int cpu, int node)
{
numa_cpu_lookup_table[cpu] = node;

dbg("adding cpu %d to node %d\n", cpu, node);

if (!(cpu_isset(cpu, numa_cpumask_lookup_table[node])))
cpu_set(cpu, numa_cpumask_lookup_table[node]);
}
Expand Down Expand Up @@ -246,8 +248,7 @@ static int __init find_min_common_depth(void)
if ((len >= 1) && ref_points) {
depth = ref_points[1];
} else {
dbg("WARNING: could not find NUMA "
"associativity reference point\n");
dbg("NUMA: ibm,associativity-reference-points not found.\n");
depth = -1;
}
of_node_put(rtas_root);
Expand Down Expand Up @@ -385,10 +386,11 @@ static int __init parse_numa_properties(void)

min_common_depth = find_min_common_depth();

dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);
if (min_common_depth < 0)
return min_common_depth;

dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);

/*
* Even though we connect cpus to numa domains later in SMP init,
* we need to know the maximum node id now. This is because each
Expand Down

0 comments on commit bf4b85b

Please sign in to comment.