Skip to content

Commit

Permalink
[media] stv0367: signedness bug in stv0367_get_tuner_freq()
Browse files Browse the repository at this point in the history
We use err to store negative error codes so it should be signed.  And
if we return an error from stv0367_get_tuner_freq() that needs to be
handled properly as well.  (param->frequency is a u32).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Dan Carpenter authored and Mauro Carvalho Chehab committed Mar 22, 2011
1 parent c6384c8 commit bf512b2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/media/dvb/frontends/stv0367.c
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ static u32 stv0367_get_tuner_freq(struct dvb_frontend *fe)
struct dvb_frontend_ops *frontend_ops = NULL;
struct dvb_tuner_ops *tuner_ops = NULL;
u32 freq = 0;
u32 err = 0;
int err = 0;

dprintk("%s:\n", __func__);

Expand Down Expand Up @@ -1940,7 +1940,7 @@ static int stv0367ter_get_frontend(struct dvb_frontend *fe,
int constell = 0,/* snr = 0,*/ Data = 0;

param->frequency = stv0367_get_tuner_freq(fe);
if (param->frequency < 0)
if ((int)param->frequency < 0)
param->frequency = c->frequency;

constell = stv0367_readbits(state, F367TER_TPS_CONST);
Expand Down

0 comments on commit bf512b2

Please sign in to comment.