Skip to content

Commit

Permalink
NFSv4.1: Handle errors in nfs4_bind_conn_to_session
Browse files Browse the repository at this point in the history
Ensure that we handle NFS4ERR_DELAY errors separately, and then
let nfs4_recovery_handle_error() handle all other cases.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed May 27, 2012
1 parent 43ac544 commit bf674c8
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion fs/nfs/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -1788,7 +1788,17 @@ static int nfs4_bind_conn_to_session(struct nfs_client *clp)
if (cred)
put_rpccred(cred);
clear_bit(NFS4CLNT_BIND_CONN_TO_SESSION, &clp->cl_state);
return ret;
switch (ret) {
case 0:
break;
case -NFS4ERR_DELAY:
ssleep(1);
set_bit(NFS4CLNT_BIND_CONN_TO_SESSION, &clp->cl_state);
break;
default:
return nfs4_recovery_handle_error(clp, ret);
}
return 0;
}
#else /* CONFIG_NFS_V4_1 */
static int nfs4_reset_session(struct nfs_client *clp) { return 0; }
Expand Down Expand Up @@ -1858,6 +1868,7 @@ static void nfs4_state_manager(struct nfs_client *clp)
status = nfs4_bind_conn_to_session(clp);
if (status < 0)
goto out_error;
continue;
}

/* First recover reboot state... */
Expand Down

0 comments on commit bf674c8

Please sign in to comment.