Skip to content

Commit

Permalink
de4x5/PCI: use list_for_each_entry() for bus->devices traversal
Browse files Browse the repository at this point in the history
Replace open-coded list traversal with list_for_each_entry().

CC: Grant Grundler <grundler@parisc-linux.org>
CC: netdev@vger.kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Bjorn Helgaas authored and David S. Miller committed Dec 19, 2011
1 parent bc12d28 commit bf684f6
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/net/ethernet/dec/tulip/de4x5.c
Original file line number Diff line number Diff line change
Expand Up @@ -2127,14 +2127,9 @@ srom_search(struct net_device *dev, struct pci_dev *pdev)
u_long iobase = 0; /* Clear upper 32 bits in Alphas */
int i, j;
struct de4x5_private *lp = netdev_priv(dev);
struct list_head *walk;

list_for_each(walk, &pdev->bus_list) {
struct pci_dev *this_dev = pci_dev_b(walk);

/* Skip the pci_bus list entry */
if (list_entry(walk, struct pci_bus, devices) == pdev->bus) continue;
struct pci_dev *this_dev;

list_for_each_entry(this_dev, &pdev->bus->devices, bus_list) {
vendor = this_dev->vendor;
device = this_dev->device << 8;
if (!(is_DC21040 || is_DC21041 || is_DC21140 || is_DC2114x)) continue;
Expand Down

0 comments on commit bf684f6

Please sign in to comment.