Skip to content

Commit

Permalink
IB/mlx4: Fix memory leaks in ib_link_query_port()
Browse files Browse the repository at this point in the history
If the call to mlx4_MAD_IFC() fails in ib_link_query_port() we will
currently do 'return err;' which will leak 'in_mad' and 'out_mad'.  We
should instead do 'goto out;' where we'll properly free the memory we
previously allocated.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Jesper Juhl authored and Roland Dreier committed Apr 24, 2012
1 parent 0034102 commit bf6b47d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mlx4/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ static int ib_link_query_port(struct ib_device *ibdev, u8 port,
err = mlx4_MAD_IFC(to_mdev(ibdev), 1, 1, port,
NULL, NULL, in_mad, out_mad);
if (err)
return err;
goto out;

/* Checking LinkSpeedActive for FDR-10 */
if (out_mad->data[15] & 0x1)
Expand Down

0 comments on commit bf6b47d

Please sign in to comment.