Skip to content

Commit

Permalink
[IRDA]: Possible cleanups.
Browse files Browse the repository at this point in the history
This patch contains the following possible cleanups:

- make the following needlessly global function static:
  - irnet/irnet_ppp.c: irnet_init

- remove the following unneeded EXPORT_SYMBOL's:
  - irlmp.c: sysctl_discovery_timeout
  - irlmp.c: irlmp_reasons
  - irlmp.c: irlmp_dup
  - irqueue.c: hashbin_find_next

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Adrian Bunk authored and David S. Miller committed Aug 29, 2005
1 parent 4c6ea29 commit bf73d1c
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
3 changes: 0 additions & 3 deletions net/irda/irlmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ struct irlmp_cb *irlmp = NULL;
/* These can be altered by the sysctl interface */
int sysctl_discovery = 0;
int sysctl_discovery_timeout = 3; /* 3 seconds by default */
EXPORT_SYMBOL(sysctl_discovery_timeout);
int sysctl_discovery_slots = 6; /* 6 slots by default */
int sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
char sysctl_devname[65];
Expand All @@ -67,7 +66,6 @@ const char *irlmp_reasons[] = {
"LM_INIT_DISCONNECT",
"ERROR, NOT USED",
};
EXPORT_SYMBOL(irlmp_reasons);

/*
* Function irlmp_init (void)
Expand Down Expand Up @@ -675,7 +673,6 @@ struct lsap_cb *irlmp_dup(struct lsap_cb *orig, void *instance)

return new;
}
EXPORT_SYMBOL(irlmp_dup);

/*
* Function irlmp_disconnect_request (handle, userdata)
Expand Down
3 changes: 0 additions & 3 deletions net/irda/irnet/irnet.h
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,6 @@ extern int
irda_irnet_init(void); /* Initialise IrDA part of IrNET */
extern void
irda_irnet_cleanup(void); /* Teardown IrDA part of IrNET */
/* ---------------------------- MODULE ---------------------------- */
extern int
irnet_init(void); /* Initialise IrNET module */

/**************************** VARIABLES ****************************/

Expand Down
2 changes: 1 addition & 1 deletion net/irda/irnet/irnet_ppp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ ppp_irnet_cleanup(void)
/*
* Module main entry point
*/
int __init
static int __init
irnet_init(void)
{
int err;
Expand Down
1 change: 0 additions & 1 deletion net/irda/irqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,6 @@ void* hashbin_find_next( hashbin_t* hashbin, long hashv, const char* name,

return entry;
}
EXPORT_SYMBOL(hashbin_find_next);

/*
* Function hashbin_get_first (hashbin)
Expand Down

0 comments on commit bf73d1c

Please sign in to comment.