Skip to content

Commit

Permalink
memcg: __mem_cgroup_free: remove stale disarm_static_keys comment
Browse files Browse the repository at this point in the history
cpuset code stopped using cgroup_lock in favor of cpuset_mutex long ago.

Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Vladimir Davydov authored and Linus Torvalds committed Dec 13, 2014
1 parent b5be83e commit bfda7e8
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions mm/memcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -4724,17 +4724,6 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg)

free_percpu(memcg->stat);

/*
* We need to make sure that (at least for now), the jump label
* destruction code runs outside of the cgroup lock. This is because
* get_online_cpus(), which is called from the static_branch update,
* can't be called inside the cgroup_lock. cpusets are the ones
* enforcing this dependency, so if they ever change, we might as well.
*
* schedule_work() will guarantee this happens. Be careful if you need
* to move this code around, and make sure it is outside
* the cgroup_lock.
*/
disarm_static_keys(memcg);
kfree(memcg);
}
Expand Down

0 comments on commit bfda7e8

Please sign in to comment.