Skip to content

Commit

Permalink
ide-tape: remove superfluous tape->lock
Browse files Browse the repository at this point in the history
tape->lock is not needed (->queue_lock protects queue).

Acked-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Mar 27, 2009
1 parent cc49555 commit bfdb0b3
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/ide/ide-tape.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,6 @@ typedef struct ide_tape_obj {
/* Wasted space in each stage */
int excess_bh_size;

/* protects the ide-tape queue */
spinlock_t lock;

/* Measures average tape speed */
unsigned long avg_time;
int avg_size;
Expand Down Expand Up @@ -481,7 +478,6 @@ static int idetape_end_request(ide_drive_t *drive, int uptodate, int nr_sects)
{
struct request *rq = drive->hwif->rq;
idetape_tape_t *tape = drive->driver_data;
unsigned long flags;
int error;

debug_log(DBG_PROCS, "Enter %s\n", __func__);
Expand All @@ -500,11 +496,8 @@ static int idetape_end_request(ide_drive_t *drive, int uptodate, int nr_sects)
return 0;
}

spin_lock_irqsave(&tape->lock, flags);

ide_complete_rq(drive, 0);

spin_unlock_irqrestore(&tape->lock, flags);
return 0;
}

Expand Down Expand Up @@ -2192,8 +2185,6 @@ static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int minor)
drive->pc_update_buffers = idetape_update_buffers;
drive->pc_io_buffers = ide_tape_io_buffers;

spin_lock_init(&tape->lock);

drive->dev_flags |= IDE_DFLAG_DSC_OVERLAP;

if (drive->hwif->host_flags & IDE_HFLAG_NO_DSC) {
Expand Down

0 comments on commit bfdb0b3

Please sign in to comment.