Skip to content

Commit

Permalink
Merge branch 'fixes-for-3.5' of git://git.kernel.org/pub/scm/linux/ke…
Browse files Browse the repository at this point in the history
…rnel/git/cooloney/linux-leds

Pull led fixes from Bryan Wu.

* 'fixes-for-3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds:
  leds: Make LEDS_ASIC3 and LEDS_RENESAS_TPU depend on LEDS_CLASS=y
  leds: fixed a coding style issue.
  leds: don't disable blinking when writing the same value to delay_on or delay_off
  • Loading branch information
Linus Torvalds committed Jun 13, 2012
2 parents 6ddb990 + 9473c4c commit c02feee
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
4 changes: 2 additions & 2 deletions drivers/leds/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ config LEDS_NETXBIG

config LEDS_ASIC3
bool "LED support for the HTC ASIC3"
depends on LEDS_CLASS
depends on LEDS_CLASS=y
depends on MFD_ASIC3
default y
help
Expand All @@ -390,7 +390,7 @@ config LEDS_ASIC3

config LEDS_RENESAS_TPU
bool "LED support for Renesas TPU"
depends on LEDS_CLASS && HAVE_CLK && GENERIC_GPIO
depends on LEDS_CLASS=y && HAVE_CLK && GENERIC_GPIO
help
This option enables build of the LED TPU platform driver,
suitable to drive any TPU channel on newer Renesas SoCs.
Expand Down
2 changes: 1 addition & 1 deletion drivers/leds/led-class.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ static void led_update_brightness(struct led_classdev *led_cdev)
led_cdev->brightness = led_cdev->brightness_get(led_cdev);
}

static ssize_t led_brightness_show(struct device *dev,
static ssize_t led_brightness_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
Expand Down
7 changes: 0 additions & 7 deletions drivers/leds/led-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,6 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
if (!led_cdev->blink_brightness)
led_cdev->blink_brightness = led_cdev->max_brightness;

if (led_get_trigger_data(led_cdev) &&
delay_on == led_cdev->blink_delay_on &&
delay_off == led_cdev->blink_delay_off)
return;

led_stop_software_blink(led_cdev);

led_cdev->blink_delay_on = delay_on;
led_cdev->blink_delay_off = delay_off;

Expand Down

0 comments on commit c02feee

Please sign in to comment.