Skip to content

Commit

Permalink
Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/ke…
Browse files Browse the repository at this point in the history
…rnel/git/mchehab/linux-2.6

* 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6:
  saa7146: stop DMA before de-allocating DMA scatter/gather page buffers
  V4L/DVB: saa7134: remove stray unlock_kernel
  • Loading branch information
Linus Torvalds committed Feb 4, 2010
2 parents c1c0cbb + ba9e9f3 commit c031d52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions drivers/media/common/saa7146_video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1333,9 +1333,9 @@ static void buffer_release(struct videobuf_queue *q, struct videobuf_buffer *vb)

DEB_CAP(("vbuf:%p\n",vb));

release_all_pagetables(dev, buf);

saa7146_dma_free(dev,q,buf);

release_all_pagetables(dev, buf);
}

static struct videobuf_queue_ops video_qops = {
Expand Down
8 changes: 3 additions & 5 deletions drivers/media/video/saa7134/saa7134-empress.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ static int ts_open(struct file *file)
dprintk("open dev=%s\n", video_device_node_name(vdev));
err = -EBUSY;
if (!mutex_trylock(&dev->empress_tsq.vb_lock))
goto done;
return err;
if (atomic_read(&dev->empress_users))
goto done_up;
goto done;

/* Unmute audio */
saa_writeb(SAA7134_AUDIO_MUTE_CTRL,
Expand All @@ -105,10 +105,8 @@ static int ts_open(struct file *file)
file->private_data = dev;
err = 0;

done_up:
mutex_unlock(&dev->empress_tsq.vb_lock);
done:
unlock_kernel();
mutex_unlock(&dev->empress_tsq.vb_lock);
return err;
}

Expand Down

0 comments on commit c031d52

Please sign in to comment.