Skip to content

Commit

Permalink
[IA64] Force error to surface in nofault code
Browse files Browse the repository at this point in the history
Montecito behaves slightly differently than previous processors,
resulting in the MCA due to a failed PIO read to sometimes surfacing
outside the nofault code.  Adding an additional or and stop bits
ensures the MCA surfaces in the nofault code.

Signed-off-by: Russ Anderson <rja@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Russ Anderson authored and Tony Luck committed Jun 26, 2007
1 parent eaf6c76 commit c034637
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/ia64/sn/kernel/xp_nofault.S
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
xp_nofault_PIOR:
mov r8=r0 // Stage a success return value
ld8.acq r9=[r32];; // PIO Read the specified register
adds r9=1,r9 // Add to force a consume
adds r9=1,r9;; // Add to force consumption
or r9=r9,r9;; // Or to force consumption
br.ret.sptk.many b0;; // Return success

.global xp_error_PIOR
Expand Down

0 comments on commit c034637

Please sign in to comment.