Skip to content

Commit

Permalink
[ARM] 3860/1: Versatile PCI config byte accesses
Browse files Browse the repository at this point in the history
The ARM Versatile board PCI config space read routines are broken for byte
accesses.  The access uses a byte read, so masking the bottom two bits of the
address is wrong.

I guess this is a cut/paste error from the the halfword code which uses
aligned word access+shift+mask.

Signed-off-by: Paul Brook <paul@codesourcery.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Paul Brook authored and Russell King committed Sep 27, 2006
1 parent 4052ebb commit c060151
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/arm/mach-versatile/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ static int versatile_read_config(struct pci_bus *bus, unsigned int devfn, int wh
} else {
switch (size) {
case 1:
addr &= ~3;
v = __raw_readb(addr);
break;

Expand Down

0 comments on commit c060151

Please sign in to comment.