Skip to content

Commit

Permalink
68360serial: Note that there isn't any info->mcr locking
Browse files Browse the repository at this point in the history
Noticed while auditing the code for the BKL elimination project

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Alan Cox authored and Linus Torvalds committed Apr 30, 2008
1 parent 6e4d376 commit c0754c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/serial/68360serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@ static int rs_360_tiocmset(struct tty_struct *tty, struct file *file,

if (tty->flags & (1 << TTY_IO_ERROR))
return -EIO;

/* FIXME: locking on info->mcr */
if (set & TIOCM_RTS)
info->mcr |= UART_MCR_RTS;
if (set & TIOCM_DTR)
Expand Down

0 comments on commit c0754c9

Please sign in to comment.