Skip to content

Commit

Permalink
ide: remove ide_pci_enablebit_t typedef
Browse files Browse the repository at this point in the history
Remove needless parens while at it.

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Jan 6, 2009
1 parent 54cc142 commit c0ae502
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/ide/setup-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ void ide_pci_setup_ports(struct pci_dev *dev, const struct ide_port_info *d,
*/

for (port = 0; port < channels; ++port) {
const ide_pci_enablebit_t *e = &(d->enablebits[port]);
const struct ide_pci_enablebit *e = &d->enablebits[port];

if (e->reg && (pci_read_config_byte(dev, e->reg, &tmp) ||
(tmp & e->mask) != e->val)) {
Expand Down
7 changes: 4 additions & 3 deletions include/linux/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -1300,11 +1300,11 @@ static inline int ide_hwif_setup_dma(ide_hwif_t *hwif,
}
#endif

typedef struct ide_pci_enablebit_s {
struct ide_pci_enablebit {
u8 reg; /* byte pci reg holding the enable-bit */
u8 mask; /* mask to isolate the enable-bit */
u8 val; /* value of masked reg when "enabled" */
} ide_pci_enablebit_t;
};

enum {
/* Uses ISA control ports not PCI ones. */
Expand Down Expand Up @@ -1393,7 +1393,8 @@ struct ide_port_info {
const struct ide_port_ops *port_ops;
const struct ide_dma_ops *dma_ops;

ide_pci_enablebit_t enablebits[2];
struct ide_pci_enablebit enablebits[2];

hwif_chipset_t chipset;

u16 max_sectors; /* if < than the default one */
Expand Down

0 comments on commit c0ae502

Please sign in to comment.