Skip to content

Commit

Permalink
nl80211: add missing parameter clearing
Browse files Browse the repository at this point in the history
Jouni and Maxim reported an oops when using wpa_supplicant -Dnl80211,
which seems to be due to random data being contained in the crypto
settings for the assoc() command. This seems to be due to the missing
memset here, so add it -- it's certainly missing but I'm not 100%
certain that it will fix the problem.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Johannes Berg authored and John W. Linville committed Jul 29, 2009
1 parent cbdec97 commit c0b2bbd
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/wireless/nl80211.c
Original file line number Diff line number Diff line change
Expand Up @@ -3385,6 +3385,8 @@ static int nl80211_crypto_settings(struct genl_info *info,
struct cfg80211_crypto_settings *settings,
int cipher_limit)
{
memset(settings, 0, sizeof(*settings));

settings->control_port = info->attrs[NL80211_ATTR_CONTROL_PORT];

if (info->attrs[NL80211_ATTR_CIPHER_SUITES_PAIRWISE]) {
Expand Down

0 comments on commit c0b2bbd

Please sign in to comment.