Skip to content

Commit

Permalink
staging: line6: Convert simple_strtoul to strict_strtoul in variax.c
Browse files Browse the repository at this point in the history
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Shawn Bohrer authored and Greg Kroah-Hartman committed Dec 11, 2009
1 parent bb950a1 commit c0e6e7c
Showing 1 changed file with 26 additions and 5 deletions.
31 changes: 26 additions & 5 deletions drivers/staging/line6/variax.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,12 @@ static ssize_t variax_set_volume(struct device *dev,
const char *buf, size_t count)
{
struct usb_line6_variax *variax = usb_get_intfdata(to_usb_interface(dev));
int value = simple_strtoul(buf, NULL, 10);
unsigned long value;
int ret;

ret = strict_strtoul(buf, 10, &value);
if (ret)
return ret;

if (line6_transmit_parameter(&variax->line6, VARIAXMIDI_volume,
value) == 0)
Expand All @@ -211,7 +216,12 @@ static ssize_t variax_set_model(struct device *dev,
const char *buf, size_t count)
{
struct usb_line6_variax *variax = usb_get_intfdata(to_usb_interface(dev));
int value = simple_strtoul(buf, NULL, 10);
unsigned long value;
int ret;

ret = strict_strtoul(buf, 10, &value);
if (ret)
return ret;

if (line6_send_program(&variax->line6, value) == 0)
variax->model = value;
Expand All @@ -237,8 +247,14 @@ static ssize_t variax_set_active(struct device *dev,
const char *buf, size_t count)
{
struct usb_line6_variax *variax = usb_get_intfdata(to_usb_interface(dev));
int value = simple_strtoul(buf, NULL, 10) ? 1 : 0;
variax->buffer_activate[VARIAX_OFFSET_ACTIVATE] = value;
unsigned long value;
int ret;

ret = strict_strtoul(buf, 10, &value);
if (ret)
return ret;

variax->buffer_activate[VARIAX_OFFSET_ACTIVATE] = value ? 1: 0;
line6_send_raw_message_async(&variax->line6, variax->buffer_activate,
sizeof(variax_activate));
return count;
Expand All @@ -262,7 +278,12 @@ static ssize_t variax_set_tone(struct device *dev,
const char *buf, size_t count)
{
struct usb_line6_variax *variax = usb_get_intfdata(to_usb_interface(dev));
int value = simple_strtoul(buf, NULL, 10);
unsigned long value;
int ret;

ret = strict_strtoul(buf, 10, &value);
if (ret)
return ret;

if (line6_transmit_parameter(&variax->line6, VARIAXMIDI_tone,
value) == 0)
Expand Down

0 comments on commit c0e6e7c

Please sign in to comment.