Skip to content

Commit

Permalink
[XFS] endianess annotations for xfs_attr_leaf_name_remote_t
Browse files Browse the repository at this point in the history
SGI-PV: 943272
SGI-Modid: xfs-linux-melb:xfs-kern:25500a

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nathan Scott <nathans@sgi.com>
  • Loading branch information
Nathan Scott committed Mar 17, 2006
1 parent 053b575 commit c0f054e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 18 deletions.
24 changes: 10 additions & 14 deletions fs/xfs/xfs_attr_leaf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2006,11 +2006,9 @@ xfs_attr_leaf_lookup_int(xfs_dabuf_t *bp, xfs_da_args_t *args)
((entry->flags & XFS_ATTR_ROOT) != 0))
continue;
args->index = probe;
args->rmtblkno
= INT_GET(name_rmt->valueblk, ARCH_CONVERT);
args->rmtblkno = be32_to_cpu(name_rmt->valueblk);
args->rmtblkcnt = XFS_B_TO_FSB(args->dp->i_mount,
INT_GET(name_rmt->valuelen,
ARCH_CONVERT));
be32_to_cpu(name_rmt->valuelen));
return(XFS_ERROR(EEXIST));
}
}
Expand Down Expand Up @@ -2057,8 +2055,8 @@ xfs_attr_leaf_getvalue(xfs_dabuf_t *bp, xfs_da_args_t *args)
name_rmt = XFS_ATTR_LEAF_NAME_REMOTE(leaf, args->index);
ASSERT(name_rmt->namelen == args->namelen);
ASSERT(memcmp(args->name, name_rmt->name, args->namelen) == 0);
valuelen = INT_GET(name_rmt->valuelen, ARCH_CONVERT);
args->rmtblkno = INT_GET(name_rmt->valueblk, ARCH_CONVERT);
valuelen = be32_to_cpu(name_rmt->valuelen);
args->rmtblkno = be32_to_cpu(name_rmt->valueblk);
args->rmtblkcnt = XFS_B_TO_FSB(args->dp->i_mount, valuelen);
if (args->flags & ATTR_KERNOVAL) {
args->valuelen = valuelen;
Expand Down Expand Up @@ -2413,8 +2411,7 @@ xfs_attr_leaf_list_int(xfs_dabuf_t *bp, xfs_attr_list_context_t *context)
retval = xfs_attr_put_listent(context, namesp,
(char *)name_rmt->name,
(int)name_rmt->namelen,
(int)INT_GET(name_rmt->valuelen,
ARCH_CONVERT));
be32_to_cpu(name_rmt->valuelen));
}
}
if (retval == 0) {
Expand Down Expand Up @@ -2549,8 +2546,8 @@ xfs_attr_leaf_clearflag(xfs_da_args_t *args)
if (args->rmtblkno) {
ASSERT((entry->flags & XFS_ATTR_LOCAL) == 0);
name_rmt = XFS_ATTR_LEAF_NAME_REMOTE(leaf, args->index);
INT_SET(name_rmt->valueblk, ARCH_CONVERT, args->rmtblkno);
INT_SET(name_rmt->valuelen, ARCH_CONVERT, args->valuelen);
name_rmt->valueblk = cpu_to_be32(args->rmtblkno);
name_rmt->valuelen = cpu_to_be32(args->valuelen);
xfs_da_log_buf(args->trans, bp,
XFS_DA_LOGRANGE(leaf, name_rmt, sizeof(*name_rmt)));
}
Expand Down Expand Up @@ -2703,8 +2700,8 @@ xfs_attr_leaf_flipflags(xfs_da_args_t *args)
if (args->rmtblkno) {
ASSERT((entry1->flags & XFS_ATTR_LOCAL) == 0);
name_rmt = XFS_ATTR_LEAF_NAME_REMOTE(leaf1, args->index);
INT_SET(name_rmt->valueblk, ARCH_CONVERT, args->rmtblkno);
INT_SET(name_rmt->valuelen, ARCH_CONVERT, args->valuelen);
name_rmt->valueblk = cpu_to_be32(args->rmtblkno);
name_rmt->valuelen = cpu_to_be32(args->valuelen);
xfs_da_log_buf(args->trans, bp1,
XFS_DA_LOGRANGE(leaf1, name_rmt, sizeof(*name_rmt)));
}
Expand Down Expand Up @@ -2953,8 +2950,7 @@ xfs_attr_leaf_inactive(xfs_trans_t **trans, xfs_inode_t *dp, xfs_dabuf_t *bp)
lp->valueblk = name_rmt->valueblk;
INT_SET(lp->valuelen, ARCH_CONVERT,
XFS_B_TO_FSB(dp->i_mount,
INT_GET(name_rmt->valuelen,
ARCH_CONVERT)));
be32_to_cpu(name_rmt->valuelen)));
lp++;
}
}
Expand Down
8 changes: 4 additions & 4 deletions fs/xfs/xfs_attr_leaf.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ typedef struct xfs_attr_leaf_name_local {
} xfs_attr_leaf_name_local_t;

typedef struct xfs_attr_leaf_name_remote {
xfs_dablk_t valueblk; /* block number of value bytes */
__uint32_t valuelen; /* number of bytes in value */
__uint8_t namelen; /* length of name bytes */
__uint8_t name[1]; /* name bytes */
__be32 valueblk; /* block number of value bytes */
__be32 valuelen; /* number of bytes in value */
__u8 namelen; /* length of name bytes */
__u8 name[1]; /* name bytes */
} xfs_attr_leaf_name_remote_t;

typedef struct xfs_attr_leafblock {
Expand Down

0 comments on commit c0f054e

Please sign in to comment.