Skip to content

Commit

Permalink
mips: undo locking on error path returns
Browse files Browse the repository at this point in the history
[akpm@linux-foundation.org: coding-style cleanups]
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Roel Kluin authored and Linus Torvalds committed Nov 15, 2007
1 parent 5c6ff79 commit c0f2a9d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions arch/mips/kernel/irixsig.c
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ asmlinkage int irix_sigprocmask(int how, irix_sigset_t __user *new,
break;

default:
spin_unlock_irq(&current->sighand->siglock);
return -EINVAL;
}
recalc_sigpending();
Expand Down
2 changes: 2 additions & 0 deletions arch/mips/vr41xx/common/icu.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,7 @@ static inline int set_sysint1_assign(unsigned int irq, unsigned char assign)
intassign1 |= (uint16_t)assign << 9;
break;
default:
spin_unlock_irq(&desc->lock);
return -EINVAL;
}

Expand Down Expand Up @@ -592,6 +593,7 @@ static inline int set_sysint2_assign(unsigned int irq, unsigned char assign)
intassign3 |= (uint16_t)assign << 12;
break;
default:
spin_unlock_irq(&desc->lock);
return -EINVAL;
}

Expand Down

0 comments on commit c0f2a9d

Please sign in to comment.