Skip to content

Commit

Permalink
nfsd4: set cl_minorversion at create time
Browse files Browse the repository at this point in the history
And remove some mostly obsolete comments.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Oct 1, 2012
1 parent 68eb350 commit c116a0a
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -1667,6 +1667,7 @@ nfsd4_exchange_id(struct svc_rqst *rqstp,
status = nfserr_jukebox;
goto out;
}
new->cl_minorversion = 1;

gen_clid(new);
add_to_unconfirmed(new, strhashval);
Expand Down Expand Up @@ -1799,12 +1800,6 @@ nfsd4_create_session(struct svc_rqst *rqstp,
status = nfserr_stale_clientid;
goto out;
}

/*
* XXX: we should probably set this at creation time, and check
* for consistent minorversion use throughout:
*/
conf->cl_minorversion = 1;
/*
* We do not support RDMA or persistent sessions
*/
Expand Down Expand Up @@ -2216,10 +2211,6 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
copy_clid(new, conf);
else /* case 4 (new client) or cases 2, 3 (client reboot): */
gen_clid(new);
/*
* XXX: we should probably set this at creation time, and check
* for consistent minorversion use throughout:
*/
new->cl_minorversion = 0;
gen_callback(new, setclid, rqstp);
add_to_unconfirmed(new, strhashval);
Expand Down

0 comments on commit c116a0a

Please sign in to comment.