Skip to content

Commit

Permalink
staging: xgifb: eliminate XGIfb_fix
Browse files Browse the repository at this point in the history
Eliminate XGIfb_fix and initialize needed fields of fb_info->fix
in probe().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Aaro Koskinen authored and Greg Kroah-Hartman committed Oct 12, 2011
1 parent e9865d4 commit c11d0ef
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
7 changes: 0 additions & 7 deletions drivers/staging/xgifb/XGI_main.h
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);

/* ------------------- Global Variables ----------------------------- */

static struct fb_fix_screeninfo XGIfb_fix = {
.id = "XGI",
.type = FB_TYPE_PACKED_PIXELS,
.xpanstep = 1,
.ypanstep = 1,
};

/* display status */
static int XGIfb_crt1off;
static int XGIfb_forcecrt1 = -1;
Expand Down
6 changes: 5 additions & 1 deletion drivers/staging/xgifb/XGI_main_26.c
Original file line number Diff line number Diff line change
Expand Up @@ -2390,8 +2390,12 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,

}

strncpy(fb_info->fix.id, "XGI", sizeof(fb_info->fix.id) - 1);
fb_info->fix.type = FB_TYPE_PACKED_PIXELS;
fb_info->fix.xpanstep = 1;
fb_info->fix.ypanstep = 1;

fb_info->flags = FBINFO_FLAG_DEFAULT;
fb_info->fix = XGIfb_fix;
fb_info->screen_base = xgifb_info->video_vbase;
fb_info->fbops = &XGIfb_ops;
XGIfb_get_fix(&fb_info->fix, -1, fb_info);
Expand Down

0 comments on commit c11d0ef

Please sign in to comment.