Skip to content

Commit

Permalink
i40e: clear test state bit after all ethtool tests
Browse files Browse the repository at this point in the history
Fix a bug where the TESTING state was still set when
exiting the ethtool diagnostics.

Change-Id: Ic47950d2e86a67167d1d282256d477cecd86d820
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Shannon Nelson authored and Jeff Kirsher committed Dec 7, 2013
1 parent ac6c5e3 commit c140c17
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/ethernet/intel/i40e/i40e_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -805,9 +805,10 @@ static void i40e_diag_test(struct net_device *netdev,
data[I40E_ETH_TEST_EEPROM] = 0;
data[I40E_ETH_TEST_INTR] = 0;
data[I40E_ETH_TEST_LOOPBACK] = 0;

clear_bit(__I40E_TESTING, &pf->state);
}
clear_bit(__I40E_TESTING, &pf->state);

netdev_info(netdev, "testing finished\n");
}

static void i40e_get_wol(struct net_device *netdev,
Expand Down

0 comments on commit c140c17

Please sign in to comment.