Skip to content

Commit

Permalink
[PATCH] libata: minor patch before moving err_mask
Browse files Browse the repository at this point in the history
  - add qc to ata_pio_poll()
  - reorder the initialization of qc in ata_pio_complete()

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>

===================
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Albert Lee authored and Jeff Garzik committed Dec 6, 2005
1 parent f38f2a2 commit c14b833
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2802,10 +2802,14 @@ void ata_poll_qc_complete(struct ata_queued_cmd *qc, unsigned int err_mask)

static unsigned long ata_pio_poll(struct ata_port *ap)
{
struct ata_queued_cmd *qc;
u8 status;
unsigned int poll_state = HSM_ST_UNKNOWN;
unsigned int reg_state = HSM_ST_UNKNOWN;

qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);

switch (ap->hsm_task_state) {
case HSM_ST:
case HSM_ST_POLL:
Expand Down Expand Up @@ -2870,15 +2874,15 @@ static int ata_pio_complete (struct ata_port *ap)
}
}

qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);

drv_stat = ata_wait_idle(ap);
if (!ata_ok(drv_stat)) {
ap->hsm_task_state = HSM_ST_ERR;
return 0;
}

qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);

ap->hsm_task_state = HSM_ST_IDLE;

ata_poll_qc_complete(qc, 0);
Expand Down

0 comments on commit c14b833

Please sign in to comment.