Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 67351
b: refs/heads/master
c: 74de08b
h: refs/heads/master
i:
  67349: a770212
  67347: f9b4295
  67343: c20fe44
v: v3
  • Loading branch information
Michael Ellerman authored and Paul Mackerras committed Sep 19, 2007
1 parent bbc6764 commit c1a8350
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 26 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 936d5bf1d7dc69c56bf79ad68819e597307a1884
refs/heads/master: 74de08bc10dd4d67870cf5b6c5aaf6875cd869c5
40 changes: 16 additions & 24 deletions trunk/arch/powerpc/platforms/cell/spufs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1085,9 +1085,8 @@ static void spufs_signal1_type_set(void *data, u64 val)
spu_release(ctx);
}

static u64 __spufs_signal1_type_get(void *data)
static u64 __spufs_signal1_type_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
return ctx->ops->signal1_type_get(ctx);
}

Expand All @@ -1097,7 +1096,7 @@ static u64 spufs_signal1_type_get(void *data)
u64 ret;

spu_acquire(ctx);
ret = __spufs_signal1_type_get(data);
ret = __spufs_signal1_type_get(ctx);
spu_release(ctx);

return ret;
Expand All @@ -1114,9 +1113,8 @@ static void spufs_signal2_type_set(void *data, u64 val)
spu_release(ctx);
}

static u64 __spufs_signal2_type_get(void *data)
static u64 __spufs_signal2_type_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
return ctx->ops->signal2_type_get(ctx);
}

Expand All @@ -1126,7 +1124,7 @@ static u64 spufs_signal2_type_get(void *data)
u64 ret;

spu_acquire(ctx);
ret = __spufs_signal2_type_get(data);
ret = __spufs_signal2_type_get(ctx);
spu_release(ctx);

return ret;
Expand Down Expand Up @@ -1629,9 +1627,8 @@ static void spufs_decr_set(void *data, u64 val)
spu_release_saved(ctx);
}

static u64 __spufs_decr_get(void *data)
static u64 __spufs_decr_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
struct spu_lscsa *lscsa = ctx->csa.lscsa;
return lscsa->decr.slot[0];
}
Expand All @@ -1641,7 +1638,7 @@ static u64 spufs_decr_get(void *data)
struct spu_context *ctx = data;
u64 ret;
spu_acquire_saved(ctx);
ret = __spufs_decr_get(data);
ret = __spufs_decr_get(ctx);
spu_release_saved(ctx);
return ret;
}
Expand All @@ -1659,9 +1656,8 @@ static void spufs_decr_status_set(void *data, u64 val)
spu_release_saved(ctx);
}

static u64 __spufs_decr_status_get(void *data)
static u64 __spufs_decr_status_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
if (ctx->csa.priv2.mfc_control_RW & MFC_CNTL_DECREMENTER_RUNNING)
return SPU_DECR_STATUS_RUNNING;
else
Expand All @@ -1673,7 +1669,7 @@ static u64 spufs_decr_status_get(void *data)
struct spu_context *ctx = data;
u64 ret;
spu_acquire_saved(ctx);
ret = __spufs_decr_status_get(data);
ret = __spufs_decr_status_get(ctx);
spu_release_saved(ctx);
return ret;
}
Expand All @@ -1689,9 +1685,8 @@ static void spufs_event_mask_set(void *data, u64 val)
spu_release_saved(ctx);
}

static u64 __spufs_event_mask_get(void *data)
static u64 __spufs_event_mask_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
struct spu_lscsa *lscsa = ctx->csa.lscsa;
return lscsa->event_mask.slot[0];
}
Expand All @@ -1701,16 +1696,15 @@ static u64 spufs_event_mask_get(void *data)
struct spu_context *ctx = data;
u64 ret;
spu_acquire_saved(ctx);
ret = __spufs_event_mask_get(data);
ret = __spufs_event_mask_get(ctx);
spu_release_saved(ctx);
return ret;
}
DEFINE_SIMPLE_ATTRIBUTE(spufs_event_mask_ops, spufs_event_mask_get,
spufs_event_mask_set, "0x%llx\n")

static u64 __spufs_event_status_get(void *data)
static u64 __spufs_event_status_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
struct spu_state *state = &ctx->csa;
u64 stat;
stat = state->spu_chnlcnt_RW[0];
Expand All @@ -1725,7 +1719,7 @@ static u64 spufs_event_status_get(void *data)
u64 ret = 0;

spu_acquire_saved(ctx);
ret = __spufs_event_status_get(data);
ret = __spufs_event_status_get(ctx);
spu_release_saved(ctx);
return ret;
}
Expand Down Expand Up @@ -1770,16 +1764,15 @@ static u64 spufs_id_get(void *data)
}
DEFINE_SIMPLE_ATTRIBUTE(spufs_id_ops, spufs_id_get, NULL, "0x%llx\n")

static u64 __spufs_object_id_get(void *data)
static u64 __spufs_object_id_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
return ctx->object_id;
}

static u64 spufs_object_id_get(void *data)
{
/* FIXME: Should there really be no locking here? */
return __spufs_object_id_get(data);
return __spufs_object_id_get((struct spu_context *)data);
}

static void spufs_object_id_set(void *data, u64 id)
Expand All @@ -1791,9 +1784,8 @@ static void spufs_object_id_set(void *data, u64 id)
DEFINE_SIMPLE_ATTRIBUTE(spufs_object_id_ops, spufs_object_id_get,
spufs_object_id_set, "0x%llx\n");

static u64 __spufs_lslr_get(void *data)
static u64 __spufs_lslr_get(struct spu_context *ctx)
{
struct spu_context *ctx = data;
return ctx->csa.priv2.spu_lslr_RW;
}

Expand All @@ -1803,7 +1795,7 @@ static u64 spufs_lslr_get(void *data)
u64 ret;

spu_acquire_saved(ctx);
ret = __spufs_lslr_get(data);
ret = __spufs_lslr_get(ctx);
spu_release_saved(ctx);

return ret;
Expand Down
2 changes: 1 addition & 1 deletion trunk/arch/powerpc/platforms/cell/spufs/spufs.h
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ struct spufs_coredump_reader {
char *name;
ssize_t (*read)(struct spu_context *ctx,
char __user *buffer, size_t size, loff_t *pos);
u64 (*get)(void *data);
u64 (*get)(struct spu_context *ctx);
size_t size;
};
extern struct spufs_coredump_reader spufs_coredump_read[];
Expand Down

0 comments on commit c1a8350

Please sign in to comment.