[PATCH] Reindent macros in pda.h

Reindent the macros in x86-64 pda.h, making them much more readable. Follows Jeremy's i386 version of this. No functional changes Signed-off-by: Andi Kleen <ak@suse.de>
git-mirror · Sep 26, 2006 · c1a9d41 · c1a9d41
1 parent 383d079
commit c1a9d41
Showing 1 changed file with 53 additions and 32 deletions.
diff --git a/include/asm-x86_64/pda.h b/include/asm-x86_64/pda.h
@@ -41,46 +41,67 @@ extern struct x8664_pda boot_cpu_pda[];
  */ 
 extern void __bad_pda_field(void);
 
-/* proxy_pda doesn't actually exist, but tell gcc it is accessed
-   for all PDA accesses so it gets read/write dependencies right. */
+/*
+ * proxy_pda doesn't actually exist, but tell gcc it is accessed for
+ * all PDA accesses so it gets read/write dependencies right.
+ */
 extern struct x8664_pda _proxy_pda;
 
 #define pda_offset(field) offsetof(struct x8664_pda, field)
 
-#define pda_to_op(op,field,val) do { \
-	typedef typeof(_proxy_pda.field) T__; \
-	if (0) { T__ tmp__; tmp__ = (val); }  \
-	switch (sizeof(_proxy_pda.field)) { 		\
-case 2: \
-asm(op "w %1,%%gs:%c2" : "+m" (_proxy_pda.field) : \
-	"ri" ((T__)val),"i"(pda_offset(field))); break; \
-case 4: \
-asm(op "l %1,%%gs:%c2" : "+m" (_proxy_pda.field) : \
-	"ri" ((T__)val),"i"(pda_offset(field))); break; \
-case 8: \
-asm(op "q %1,%%gs:%c2": "+m" (_proxy_pda.field) : \
-	 "ri" ((T__)val),"i"(pda_offset(field))); break; \
-default: __bad_pda_field(); 					\
-       } \
+#define pda_to_op(op,field,val) do {		\
+	typedef typeof(_proxy_pda.field) T__;	\
+	if (0) { T__ tmp__; tmp__ = (val); }	/* type checking */ \
+	switch (sizeof(_proxy_pda.field)) {	\
+	case 2:					\
+		asm(op "w %1,%%gs:%c2" : 	\
+		    "+m" (_proxy_pda.field) :	\
+		    "ri" ((T__)val),		\
+		    "i"(pda_offset(field))); 	\
+ 		break;				\
+	case 4:					\
+		asm(op "l %1,%%gs:%c2" : 	\
+		    "+m" (_proxy_pda.field) :	\
+		    "ri" ((T__)val),		\
+		    "i" (pda_offset(field))); 	\
+		break;				\
+	case 8:					\
+		asm(op "q %1,%%gs:%c2": 	\
+		    "+m" (_proxy_pda.field) :	\
+		    "ri" ((T__)val),		\
+		    "i"(pda_offset(field))); 	\
+		break;				\
+       default: 				\
+		__bad_pda_field();		\
+       }					\
        } while (0)
 
-#define pda_from_op(op,field) ({ \
-       typeof(_proxy_pda.field) ret__; \
-       switch (sizeof(_proxy_pda.field)) { 		\
-case 2: \
-asm(op "w %%gs:%c1,%0":"=r" (ret__):\
-	"i" (pda_offset(field)), "m" (_proxy_pda.field)); break;\
-case 4: \
-asm(op "l %%gs:%c1,%0":"=r" (ret__):\
-	"i" (pda_offset(field)), "m" (_proxy_pda.field)); break;\
-case 8: \
-asm(op "q %%gs:%c1,%0":"=r" (ret__):\
-	"i" (pda_offset(field)), "m" (_proxy_pda.field)); break;\
-default: __bad_pda_field(); 					\
-       } \
+#define pda_from_op(op,field) ({		\
+	typeof(_proxy_pda.field) ret__;		\
+	switch (sizeof(_proxy_pda.field)) {	\
+       	case 2:					\
+		asm(op "w %%gs:%c1,%0" : 	\
+		    "=r" (ret__) :		\
+		    "i" (pda_offset(field)), 	\
+		    "m" (_proxy_pda.field)); 	\
+		 break;				\
+	case 4:					\
+		asm(op "l %%gs:%c1,%0":		\
+		    "=r" (ret__):		\
+		    "i" (pda_offset(field)), 	\
+		    "m" (_proxy_pda.field)); 	\
+		 break;				\
+       case 8:					\
+		asm(op "q %%gs:%c1,%0":		\
+		    "=r" (ret__) :		\
+		    "i" (pda_offset(field)), 	\
+		    "m" (_proxy_pda.field)); 	\
+		 break;				\
+       default: 				\
+		__bad_pda_field();		\
+       }					\
        ret__; })
 
-
 #define read_pda(field) pda_from_op("mov",field)
 #define write_pda(field,val) pda_to_op("mov",field,val)
 #define add_pda(field,val) pda_to_op("add",field,val)