Skip to content

Commit

Permalink
firmware/google: drop 'select EFI' to avoid recursive dependency
Browse files Browse the repository at this point in the history
The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI.  This
causes problems on other archs when introducing DMI support that depends
on EFI, as it results in a recursive dependency:

  arch/arm/Kconfig:1845:error: recursive dependency detected!
  arch/arm/Kconfig:1845:	symbol DMI depends on EFI

Fix by changing the 'select EFI' to a 'depends on EFI'.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Rientjes <rientjes@google.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ard Biesheuvel authored and Linus Torvalds committed Jan 28, 2014
1 parent 592f6b8 commit c2218e2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/firmware/google/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ menu "Google Firmware Drivers"

config GOOGLE_SMI
tristate "SMI interface for Google platforms"
depends on ACPI && DMI
select EFI
depends on ACPI && DMI && EFI
select EFI_VARS
help
Say Y here if you want to enable SMI callbacks for Google
Expand Down

0 comments on commit c2218e2

Please sign in to comment.