Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 309277
b: refs/heads/master
c: 29e2b09
h: refs/heads/master
i:
  309275: 31232cd
v: v3
  • Loading branch information
Tejun Heo authored and Jens Axboe committed Apr 20, 2012
1 parent 8055e53 commit c23d226
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 30 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f9fcc2d3919b8eb575b3cee9274feefafb641bca
refs/heads/master: 29e2b09ab5fa790514d47838f3c05497130908b3
46 changes: 17 additions & 29 deletions trunk/block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,33 +719,6 @@ static inline void blk_free_request(struct request_queue *q, struct request *rq)
mempool_free(rq, q->rq.rq_pool);
}

static struct request *
blk_alloc_request(struct request_queue *q, struct bio *bio, struct io_cq *icq,
unsigned int flags, gfp_t gfp_mask)
{
struct request *rq = mempool_alloc(q->rq.rq_pool, gfp_mask);

if (!rq)
return NULL;

blk_rq_init(q, rq);

rq->cmd_flags = flags | REQ_ALLOCED;

if (flags & REQ_ELVPRIV) {
rq->elv.icq = icq;
if (unlikely(elv_set_request(q, rq, bio, gfp_mask))) {
mempool_free(rq, q->rq.rq_pool);
return NULL;
}
/* @rq->elv.icq holds on to io_context until @rq is freed */
if (icq)
get_io_context(icq->ioc);
}

return rq;
}

/*
* ioc_batching returns true if the ioc is a valid batching request and
* should be given priority access to a request.
Expand Down Expand Up @@ -968,10 +941,25 @@ static struct request *get_request(struct request_queue *q, int rw_flags,
goto fail_alloc;
}

rq = blk_alloc_request(q, bio, icq, rw_flags, gfp_mask);
if (unlikely(!rq))
/* allocate and init request */
rq = mempool_alloc(q->rq.rq_pool, gfp_mask);
if (!rq)
goto fail_alloc;

blk_rq_init(q, rq);
rq->cmd_flags = rw_flags | REQ_ALLOCED;

if (rw_flags & REQ_ELVPRIV) {
rq->elv.icq = icq;
if (unlikely(elv_set_request(q, rq, bio, gfp_mask))) {
mempool_free(rq, q->rq.rq_pool);
goto fail_alloc;
}
/* @rq->elv.icq holds on to io_context until @rq is freed */
if (icq)
get_io_context(icq->ioc);
}

/*
* ioc may be NULL here, and ioc_batching will be false. That's
* OK, if the queue is under the request limit then requests need
Expand Down

0 comments on commit c23d226

Please sign in to comment.