Skip to content

Commit

Permalink
[PATCH] ocfs2: Release mutex in error handling code
Browse files Browse the repository at this point in the history
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
  • Loading branch information
Julia Lawall authored and Mark Fasheh committed Jul 31, 2008
1 parent 961cecb commit c259ae5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ocfs2/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1766,8 +1766,8 @@ static int __ocfs2_change_file_space(struct file *file, struct inode *inode,
out_rw_unlock:
ocfs2_rw_unlock(inode, 1);

mutex_unlock(&inode->i_mutex);
out:
mutex_unlock(&inode->i_mutex);
return ret;
}

Expand Down

0 comments on commit c259ae5

Please sign in to comment.