Skip to content

Commit

Permalink
brcm80211: smac: indicate severe problems to Mac80211
Browse files Browse the repository at this point in the history
In case the hardware crashes, a reinitialization internal to the driver
was performed. Since Mac80211 must be in the know of such an event as
well, ieee80211_restart_hw() is now called.

Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Roland Vossen authored and John W. Linville committed Nov 8, 2011
1 parent 0527781 commit c261bdf
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
8 changes: 8 additions & 0 deletions drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,14 @@ uint brcms_reset(struct brcms_info *wl)
return 0;
}

void brcms_fatal_error(struct brcms_info *wl)
{
wiphy_err(wl->wlc->wiphy, "wl%d: fatal error, reinitializing\n",
wl->wlc->pub->unit);
brcms_reset(wl);
ieee80211_restart_hw(wl->pub->ieee_hw);
}

/*
* These are interrupt on/off entry points. Disable interrupts
* during interrupt state transition.
Expand Down
1 change: 1 addition & 0 deletions drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,5 +104,6 @@ extern bool brcms_del_timer(struct brcms_timer *timer);
extern void brcms_msleep(struct brcms_info *wl, uint ms);
extern void brcms_dpc(unsigned long data);
extern void brcms_timer(struct brcms_timer *t);
extern void brcms_fatal_error(struct brcms_info *wl);

#endif /* _BRCM_MAC80211_IF_H_ */
14 changes: 3 additions & 11 deletions drivers/net/wireless/brcm80211/brcmsmac/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2301,13 +2301,6 @@ void brcms_b_antsel_type_set(struct brcms_hardware *wlc_hw, u8 antsel_type)
wlc_phy_antsel_type_set(wlc_hw->band->pi, antsel_type);
}

static void brcms_c_fatal_error(struct brcms_c_info *wlc)
{
wiphy_err(wlc->wiphy, "wl%d: fatal error, reinitializing\n",
wlc->pub->unit);
brcms_init(wlc->wl);
}

static void brcms_b_fifoerrors(struct brcms_hardware *wlc_hw)
{
bool fatal = false;
Expand Down Expand Up @@ -2363,7 +2356,7 @@ static void brcms_b_fifoerrors(struct brcms_hardware *wlc_hw)
}

if (fatal) {
brcms_c_fatal_error(wlc_hw->wlc); /* big hammer */
brcms_fatal_error(wlc_hw->wlc->wl); /* big hammer */
break;
} else
W_REG(&regs->intctrlregs[idx].intstatus,
Expand Down Expand Up @@ -8397,8 +8390,7 @@ bool brcms_c_dpc(struct brcms_c_info *wlc, bool bounded)
printk_once("%s : PSM Watchdog, chipid 0x%x, chiprev 0x%x\n",
__func__, wlc_hw->sih->chip,
wlc_hw->sih->chiprev);
/* big hammer */
brcms_init(wlc->wl);
brcms_fatal_error(wlc_hw->wlc->wl);
}

/* gptimer timeout */
Expand All @@ -8419,7 +8411,7 @@ bool brcms_c_dpc(struct brcms_c_info *wlc, bool bounded)
return wlc->macintstatus != 0;

fatal:
brcms_init(wlc->wl);
brcms_fatal_error(wlc_hw->wlc->wl);
return wlc->macintstatus != 0;
}

Expand Down

0 comments on commit c261bdf

Please sign in to comment.