Skip to content

Commit

Permalink
[media] v4l: mt9p031/mt9t001: Use i2c_smbus_{read|write}_word_swapped()
Browse files Browse the repository at this point in the history
The MT9P031 and MT9T001 sensors transfer 16-bit data on the I2C bus in
swapped order. Let the I2C core handle byte order by using the
i2c_smbus_{read|write}_word_swapped() functions.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Nov 7, 2011
1 parent cfb128e commit c27e305
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions drivers/media/video/mt9p031.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,12 @@ static struct mt9p031 *to_mt9p031(struct v4l2_subdev *sd)

static int mt9p031_read(struct i2c_client *client, u8 reg)
{
s32 data = i2c_smbus_read_word_data(client, reg);
return data < 0 ? data : be16_to_cpu(data);
return i2c_smbus_read_word_swapped(client, reg);
}

static int mt9p031_write(struct i2c_client *client, u8 reg, u16 data)
{
return i2c_smbus_write_word_data(client, reg, cpu_to_be16(data));
return i2c_smbus_write_word_swapped(client, reg, data);
}

static int mt9p031_set_output_control(struct mt9p031 *mt9p031, u16 clear,
Expand Down
5 changes: 2 additions & 3 deletions drivers/media/video/mt9t001.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,12 @@ static inline struct mt9t001 *to_mt9t001(struct v4l2_subdev *sd)

static int mt9t001_read(struct i2c_client *client, u8 reg)
{
s32 data = i2c_smbus_read_word_data(client, reg);
return data < 0 ? data : be16_to_cpu(data);
return i2c_smbus_read_word_swapped(client, reg);
}

static int mt9t001_write(struct i2c_client *client, u8 reg, u16 data)
{
return i2c_smbus_write_word_data(client, reg, cpu_to_be16(data));
return i2c_smbus_write_word_swapped(client, reg, data);
}

static int mt9t001_set_output_control(struct mt9t001 *mt9t001, u16 clear,
Expand Down

0 comments on commit c27e305

Please sign in to comment.