Skip to content

Commit

Permalink
ARM: OMAP3: Beagle: fix return value check in beagle_opp_init()
Browse files Browse the repository at this point in the history
In case of error, the function get_cpu_device() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Wei Yongjun authored and Tony Lindgren committed Nov 15, 2013
1 parent 7b0d0cc commit c27f2de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/board-omap3beagle.c
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ static int __init beagle_opp_init(void)
mpu_dev = get_cpu_device(0);
iva_dev = omap_device_get_by_hwmod_name("iva");

if (IS_ERR(mpu_dev) || IS_ERR(iva_dev)) {
if (!mpu_dev || IS_ERR(iva_dev)) {
pr_err("%s: Aiee.. no mpu/dsp devices? %p %p\n",
__func__, mpu_dev, iva_dev);
return -ENODEV;
Expand Down

0 comments on commit c27f2de

Please sign in to comment.