Skip to content

Commit

Permalink
rhashtable-test: Get rid of ptr in test_obj structure
Browse files Browse the repository at this point in the history
This only blows up the size of the test structure for no gain
in test coverage. Reduces size of test_obj from 24 to 16 bytes.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thomas Graf authored and David S. Miller committed May 4, 2015
1 parent 1aa661f commit c2c8a90
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions lib/test_rhashtable.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <linux/slab.h>


#define TEST_PTR ((void *) 0xdeadbeef)
#define MAX_ENTRIES 1000000

static int entries = 50000;
Expand All @@ -46,7 +45,6 @@ module_param(size, int, 0);
MODULE_PARM_DESC(size, "Initial size hint of table (default: 8)");

struct test_obj {
void *ptr;
int value;
struct rhash_head node;
};
Expand Down Expand Up @@ -78,9 +76,9 @@ static int __init test_rht_lookup(struct rhashtable *ht)
key);
return -EEXIST;
} else if (expected && obj) {
if (obj->ptr != TEST_PTR || obj->value != i) {
pr_warn("Test failed: Lookup value mismatch %p!=%p, %u!=%u\n",
obj->ptr, TEST_PTR, obj->value, i);
if (obj->value != i) {
pr_warn("Test failed: Lookup value mismatch %u!=%u\n",
obj->value, i);
return -EINVAL;
}
}
Expand Down Expand Up @@ -153,7 +151,6 @@ static s64 __init test_rhashtable(struct rhashtable *ht)
goto error;
}

obj->ptr = TEST_PTR;
obj->value = i * 2;

err = rhashtable_insert_fast(ht, &obj->node, test_rht_params);
Expand Down

0 comments on commit c2c8a90

Please sign in to comment.