Skip to content

Commit

Permalink
gxt4500: use display information in info not in var for panning
Browse files Browse the repository at this point in the history
We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Laurent Pinchart authored and Paul Mundt committed Jun 15, 2011
1 parent c12665f commit c2d340a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/gxt4500.c
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,8 @@ static int gxt4500_pan_display(struct fb_var_screeninfo *var,

if (var->xoffset & 7)
return -EINVAL;
if (var->xoffset + var->xres > var->xres_virtual ||
var->yoffset + var->yres > var->yres_virtual)
if (var->xoffset + info->var.xres > info->var.xres_virtual ||
var->yoffset + info->var.yres > info->var.yres_virtual)
return -EINVAL;

writereg(par, REFRESH_START, (var->xoffset << 16) | var->yoffset);
Expand Down

0 comments on commit c2d340a

Please sign in to comment.