Skip to content

Commit

Permalink
x86: cleanup for setup code crashes during IST probe
Browse files Browse the repository at this point in the history
Clean up the code for crashes during SpeedStep probing on older
machines.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
H. Peter Anvin authored and Ingo Molnar committed Aug 13, 2008
1 parent 875e40b commit c2dcfde
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions arch/x86/boot/boot.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
#include <linux/edd.h>
#include <asm/boot.h>
#include <asm/setup.h>

#define NCAPINTS 8
#include "bitops.h"
#include <asm/cpufeature.h>

/* Useful macros */
#define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))
Expand Down
3 changes: 0 additions & 3 deletions arch/x86/boot/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
*/

#include "boot.h"
#include "bitops.h"
#include <asm/cpufeature.h>

#include "cpustr.h"

static char *cpu_name(int level)
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/boot/cpucheck.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@

#ifdef _SETUP
# include "boot.h"
# include "bitops.h"
#endif
#include <linux/types.h>
#include <asm/cpufeature.h>
#include <asm/processor-flags.h>
#include <asm/required-features.h>
#include <asm/msr-index.h>
Expand Down
3 changes: 2 additions & 1 deletion arch/x86/boot/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ static void keyboard_set_repeat(void)
*/
static void query_ist(void)
{
/* Some 486 BIOSes apparently crash on this call */
/* Some older BIOSes apparently crash on this call, so filter
it from machines too old to have SpeedStep at all. */
if (cpu.level < 6)
return;

Expand Down

0 comments on commit c2dcfde

Please sign in to comment.