Skip to content

Commit

Permalink
hwmon: (twl4030-madc-hwmon) Return proper error if hwmon_device_regis…
Browse files Browse the repository at this point in the history
…ter fails

The driver did not return an error if the call to hwmon_device_register failed.
Fix by returning the error reported from hwmon_device_register.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
  • Loading branch information
Axel Lin authored and Guenter Roeck committed May 1, 2011
1 parent 1be6a1f commit c30aa39
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/hwmon/twl4030-madc-hwmon.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ static const struct attribute_group twl4030_madc_group = {
static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
{
int ret;
int status;
struct device *hwmon;

ret = sysfs_create_group(&pdev->dev.kobj, &twl4030_madc_group);
Expand All @@ -107,7 +106,7 @@ static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
hwmon = hwmon_device_register(&pdev->dev);
if (IS_ERR(hwmon)) {
dev_err(&pdev->dev, "hwmon_device_register failed.\n");
status = PTR_ERR(hwmon);
ret = PTR_ERR(hwmon);
goto err_reg;
}

Expand Down

0 comments on commit c30aa39

Please sign in to comment.