Skip to content

Commit

Permalink
[GFS2] Pass the correct value to kunmap_atomic
Browse files Browse the repository at this point in the history
Pass kaddr rather than (incorrect) struct page to kunmap_atomic.

Signed-off-by: Russell Cattelan <cattelan@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Russell Cattelan authored and Steven Whitehouse committed Oct 12, 2006
1 parent fe1a698 commit c312c4f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions fs/gfs2/lops.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ static int gfs2_check_magic(struct buffer_head *bh)
ptr = kaddr + bh_offset(bh);
if (*ptr == cpu_to_be32(GFS2_MAGIC))
rv = 1;
kunmap_atomic(page, KM_USER0);
kunmap_atomic(kaddr, KM_USER0);

return rv;
}
Expand Down Expand Up @@ -626,7 +626,7 @@ static void databuf_lo_before_commit(struct gfs2_sbd *sdp)
memcpy(bh->b_data,
kaddr + bh_offset(bd2->bd_bh),
sdp->sd_sb.sb_bsize);
kunmap_atomic(page, KM_USER0);
kunmap_atomic(kaddr, KM_USER0);
*(__be32 *)bh->b_data = 0;
} else {
bh = gfs2_log_fake_buf(sdp, bd2->bd_bh);
Expand Down
6 changes: 3 additions & 3 deletions fs/gfs2/ops_address.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ static int zero_readpage(struct page *page)

kaddr = kmap_atomic(page, KM_USER0);
memset(kaddr, 0, PAGE_CACHE_SIZE);
kunmap_atomic(page, KM_USER0);
kunmap_atomic(kaddr, KM_USER0);

SetPageUptodate(page);

Expand Down Expand Up @@ -195,7 +195,7 @@ static int stuffed_readpage(struct gfs2_inode *ip, struct page *page)
memcpy(kaddr, dibh->b_data + sizeof(struct gfs2_dinode),
ip->i_di.di_size);
memset(kaddr + ip->i_di.di_size, 0, PAGE_CACHE_SIZE - ip->i_di.di_size);
kunmap_atomic(page, KM_USER0);
kunmap_atomic(kaddr, KM_USER0);

brelse(dibh);

Expand Down Expand Up @@ -485,7 +485,7 @@ static int gfs2_commit_write(struct file *file, struct page *page,
kaddr = kmap_atomic(page, KM_USER0);
memcpy(dibh->b_data + sizeof(struct gfs2_dinode) + from,
kaddr + from, to - from);
kunmap_atomic(page, KM_USER0);
kunmap_atomic(kaddr, KM_USER0);

SetPageUptodate(page);

Expand Down

0 comments on commit c312c4f

Please sign in to comment.