Skip to content

Commit

Permalink
i7core_edac: fix erroneous size of static array
Browse files Browse the repository at this point in the history
Remove size from lookup arrays and mark them as const.

Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Niklas Söderlund <niso@kth.se>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Niklas Söderlund authored and Mauro Carvalho Chehab committed Dec 21, 2012
1 parent da14d93 commit c31d34f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/edac/i7core_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -420,21 +420,21 @@ static inline int numdimms(u32 dimms)

static inline int numrank(u32 rank)
{
static int ranks[4] = { 1, 2, 4, -EINVAL };
static const int ranks[] = { 1, 2, 4, -EINVAL };

return ranks[rank & 0x3];
}

static inline int numbank(u32 bank)
{
static int banks[4] = { 4, 8, 16, -EINVAL };
static const int banks[] = { 4, 8, 16, -EINVAL };

return banks[bank & 0x3];
}

static inline int numrow(u32 row)
{
static int rows[8] = {
static const int rows[] = {
1 << 12, 1 << 13, 1 << 14, 1 << 15,
1 << 16, -EINVAL, -EINVAL, -EINVAL,
};
Expand All @@ -444,7 +444,7 @@ static inline int numrow(u32 row)

static inline int numcol(u32 col)
{
static int cols[8] = {
static const int cols[] = {
1 << 10, 1 << 11, 1 << 12, -EINVAL,
};
return cols[col & 0x3];
Expand Down

0 comments on commit c31d34f

Please sign in to comment.