Skip to content

Commit

Permalink
iwleagcy: fix ident code damage
Browse files Browse the repository at this point in the history
Using ident is not always good.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Stanislaw Gruszka authored and John W. Linville committed Feb 22, 2012
1 parent 774212b commit c37281a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 26 deletions.
18 changes: 5 additions & 13 deletions drivers/net/wireless/iwlegacy/3945-mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2272,26 +2272,18 @@ __il3945_down(struct il_priv *il)
* clear all bits but the RF Kill bits and return */
if (!il_is_init(il)) {
il->status =
test_bit(S_RF_KILL_HW,
&il->
status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED,
&il->
status) << S_GEO_CONFIGURED |
test_bit(S_RF_KILL_HW, &il->status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED, &il->status) << S_GEO_CONFIGURED |
test_bit(S_EXIT_PENDING, &il->status) << S_EXIT_PENDING;
goto exit;
}

/* ...otherwise clear out all the status bits but the RF Kill
* bit and continue taking the NIC down. */
il->status &=
test_bit(S_RF_KILL_HW,
&il->status) << S_RF_KILL_HW | test_bit(S_GEO_CONFIGURED,
&il->
status) <<
S_GEO_CONFIGURED | test_bit(S_FW_ERROR,
&il->
status) << S_FW_ERROR |
test_bit(S_RF_KILL_HW, &il->status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED, &il->status) << S_GEO_CONFIGURED |
test_bit(S_FW_ERROR, &il->status) << S_FW_ERROR |
test_bit(S_EXIT_PENDING, &il->status) << S_EXIT_PENDING;

il3945_hw_txq_ctx_stop(il);
Expand Down
18 changes: 5 additions & 13 deletions drivers/net/wireless/iwlegacy/4965-mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -5384,26 +5384,18 @@ __il4965_down(struct il_priv *il)
* clear all bits but the RF Kill bit and return */
if (!il_is_init(il)) {
il->status =
test_bit(S_RF_KILL_HW,
&il->
status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED,
&il->
status) << S_GEO_CONFIGURED |
test_bit(S_RF_KILL_HW, &il->status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED, &il->status) << S_GEO_CONFIGURED |
test_bit(S_EXIT_PENDING, &il->status) << S_EXIT_PENDING;
goto exit;
}

/* ...otherwise clear out all the status bits but the RF Kill
* bit and continue taking the NIC down. */
il->status &=
test_bit(S_RF_KILL_HW,
&il->status) << S_RF_KILL_HW | test_bit(S_GEO_CONFIGURED,
&il->
status) <<
S_GEO_CONFIGURED | test_bit(S_FW_ERROR,
&il->
status) << S_FW_ERROR |
test_bit(S_RF_KILL_HW, &il->status) << S_RF_KILL_HW |
test_bit(S_GEO_CONFIGURED, &il->status) << S_GEO_CONFIGURED |
test_bit(S_FW_ERROR, &il->status) << S_FW_ERROR |
test_bit(S_EXIT_PENDING, &il->status) << S_EXIT_PENDING;

il4965_txq_ctx_stop(il);
Expand Down

0 comments on commit c37281a

Please sign in to comment.