Skip to content

Commit

Permalink
sfc: Do not initialise buffer in efx_alloc_special_buffer()
Browse files Browse the repository at this point in the history
Currently we initialise the newly allocated buffer to all-1s, which is
important for event queues but not for descriptor queues.  And since
we also do that in efx_nic_init_eventq(), it is completely pointless
to do it here.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
  • Loading branch information
Ben Hutchings committed Dec 1, 2012
1 parent ef492f1 commit c3771a3
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/sfc/nic.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,6 @@ static int efx_alloc_special_buffer(struct efx_nic *efx,
buffer->entries = len / EFX_BUF_SIZE;
BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1));

/* All zeros is a potentially valid event so memset to 0xff */
memset(buffer->addr, 0xff, len);

/* Select new buffer ID */
buffer->index = efx->next_buffer_table;
efx->next_buffer_table += buffer->entries;
Expand Down

0 comments on commit c3771a3

Please sign in to comment.