Skip to content

Commit

Permalink
drm/i915: Fix error handler to capture the first batch after the seqno
Browse files Browse the repository at this point in the history
Whilst we had no older batches on the active list, everything was fine.
However, if the GPU is free running and the requests are only being
reaped by the periodic retirer, than the current seqno may not be at the
start of the list. In this case we need to select the first batch after
the last seqno written by the gpu and not inclusive of the seqno.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Jan 13, 2011
1 parent a761503 commit c37d9a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/i915_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ i915_error_first_batchbuffer(struct drm_i915_private *dev_priv,
if (obj->ring != ring)
continue;

if (!i915_seqno_passed(obj->last_rendering_seqno, seqno))
if (i915_seqno_passed(seqno, obj->last_rendering_seqno))
continue;

if ((obj->base.read_domains & I915_GEM_DOMAIN_COMMAND) == 0)
Expand Down

0 comments on commit c37d9a5

Please sign in to comment.