Skip to content

Commit

Permalink
[S390] cio: update descriptor in chsc_chp_vary
Browse files Browse the repository at this point in the history
Update the channel path descriptor at the beginning of to the
vary_on operation.

Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Sebastian Ott authored and Martin Schwidefsky committed Oct 25, 2010
1 parent 906c976 commit c38a90a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
6 changes: 0 additions & 6 deletions drivers/s390/cio/chp.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,6 @@ static struct work_struct cfg_work;
/* Wait queue for configure completion events. */
static wait_queue_head_t cfg_wait_queue;

/* Return channel_path struct for given chpid. */
static inline struct channel_path *chpid_to_chp(struct chp_id chpid)
{
return channel_subsystems[chpid.cssid]->chps[chpid.id];
}

/* Set vary state for given chpid. */
static void set_chp_logically_online(struct chp_id chpid, int onoff)
{
Expand Down
6 changes: 6 additions & 0 deletions drivers/s390/cio/chp.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ struct channel_path {
void *cmg_chars;
};

/* Return channel_path struct for given chpid. */
static inline struct channel_path *chpid_to_chp(struct chp_id chpid)
{
return channel_subsystems[chpid.cssid]->chps[chpid.id];
}

int chp_get_status(struct chp_id chpid);
u8 chp_get_sch_opm(struct subchannel *sch);
int chp_is_registered(struct chp_id chpid);
Expand Down
8 changes: 5 additions & 3 deletions drivers/s390/cio/chsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@ __s390_vary_chpid_on(struct subchannel_id schid, void *data)
*/
int chsc_chp_vary(struct chp_id chpid, int on)
{
struct channel_path *chp = chpid_to_chp(chpid);
struct chp_link link;

memset(&link, 0, sizeof(struct chp_link));
Expand All @@ -504,11 +505,12 @@ int chsc_chp_vary(struct chp_id chpid, int on)
/*
* Redo PathVerification on the devices the chpid connects to
*/

if (on)
if (on) {
/* Try to update the channel path descritor. */
chsc_determine_base_channel_path_desc(chpid, &chp->desc);
for_each_subchannel_staged(s390_subchannel_vary_chpid_on,
__s390_vary_chpid_on, &link);
else
} else
for_each_subchannel_staged(s390_subchannel_vary_chpid_off,
NULL, &link);

Expand Down

0 comments on commit c38a90a

Please sign in to comment.