Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 303784
b: refs/heads/master
c: 978def1
h: refs/heads/master
v: v3
  • Loading branch information
Ido Shayevitz authored and Felipe Balbi committed May 4, 2012
1 parent 7803604 commit c3d13bd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5a6506f00efa4b38b181152b69a072e766c7ce92
refs/heads/master: 978def1c4e796eebca6047b8de164c7d182494e3
24 changes: 12 additions & 12 deletions trunk/drivers/usb/gadget/atmel_usba_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -599,13 +599,13 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)

spin_lock_irqsave(&ep->udc->lock, flags);

if (ep->desc) {
if (ep->ep.desc) {
spin_unlock_irqrestore(&ep->udc->lock, flags);
DBG(DBG_ERR, "ep%d already enabled\n", ep->index);
return -EBUSY;
}

ep->desc = desc;
ep->ep.desc = desc;
ep->ep.maxpacket = maxpacket;

usba_ep_writel(ep, CFG, ept_cfg);
Expand Down Expand Up @@ -647,7 +647,7 @@ static int usba_ep_disable(struct usb_ep *_ep)

spin_lock_irqsave(&udc->lock, flags);

if (!ep->desc) {
if (!ep->ep.desc) {
spin_unlock_irqrestore(&udc->lock, flags);
/* REVISIT because this driver disables endpoints in
* reset_all_endpoints() before calling disconnect(),
Expand All @@ -658,7 +658,6 @@ static int usba_ep_disable(struct usb_ep *_ep)
ep->ep.name);
return -EINVAL;
}
ep->desc = NULL;
ep->ep.desc = NULL;

list_splice_init(&ep->queue, &req_list);
Expand Down Expand Up @@ -752,7 +751,7 @@ static int queue_dma(struct usba_udc *udc, struct usba_ep *ep,
*/
ret = -ESHUTDOWN;
spin_lock_irqsave(&udc->lock, flags);
if (ep->desc) {
if (ep->ep.desc) {
if (list_empty(&ep->queue))
submit_request(ep, req);

Expand All @@ -776,7 +775,8 @@ usba_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
DBG(DBG_GADGET | DBG_QUEUE | DBG_REQ, "%s: queue req %p, len %u\n",
ep->ep.name, req, _req->length);

if (!udc->driver || udc->gadget.speed == USB_SPEED_UNKNOWN || !ep->desc)
if (!udc->driver || udc->gadget.speed == USB_SPEED_UNKNOWN ||
!ep->ep.desc)
return -ESHUTDOWN;

req->submitted = 0;
Expand All @@ -792,7 +792,7 @@ usba_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
/* May have received a reset since last time we checked */
ret = -ESHUTDOWN;
spin_lock_irqsave(&udc->lock, flags);
if (ep->desc) {
if (ep->ep.desc) {
list_add_tail(&req->queue, &ep->queue);

if ((!ep_is_control(ep) && ep->is_in) ||
Expand Down Expand Up @@ -905,7 +905,7 @@ static int usba_ep_set_halt(struct usb_ep *_ep, int value)
DBG(DBG_GADGET, "endpoint %s: %s HALT\n", ep->ep.name,
value ? "set" : "clear");

if (!ep->desc) {
if (!ep->ep.desc) {
DBG(DBG_ERR, "Attempted to halt uninitialized ep %s\n",
ep->ep.name);
return -ENODEV;
Expand Down Expand Up @@ -1071,7 +1071,7 @@ static void reset_all_endpoints(struct usba_udc *udc)
* FIXME remove this code ... and retest thoroughly.
*/
list_for_each_entry(ep, &udc->gadget.ep_list, ep.ep_list) {
if (ep->desc) {
if (ep->ep.desc) {
spin_unlock(&udc->lock);
usba_ep_disable(&ep->ep);
spin_lock(&udc->lock);
Expand All @@ -1089,9 +1089,9 @@ static struct usba_ep *get_ep_by_addr(struct usba_udc *udc, u16 wIndex)
list_for_each_entry (ep, &udc->gadget.ep_list, ep.ep_list) {
u8 bEndpointAddress;

if (!ep->desc)
if (!ep->ep.desc)
continue;
bEndpointAddress = ep->desc->bEndpointAddress;
bEndpointAddress = ep->ep.desc->bEndpointAddress;
if ((wIndex ^ bEndpointAddress) & USB_DIR_IN)
continue;
if ((bEndpointAddress & USB_ENDPOINT_NUMBER_MASK)
Expand Down Expand Up @@ -1727,7 +1727,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
usb_speed_string(udc->gadget.speed));

ep0 = &usba_ep[0];
ep0->desc = &usba_ep0_desc;
ep0->ep.desc = &usba_ep0_desc;
ep0->state = WAIT_FOR_SETUP;
usba_ep_writel(ep0, CFG,
(USBA_BF(EPT_SIZE, EP0_EPT_SIZE)
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/usb/gadget/atmel_usba_udc.h
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ struct usba_ep {
struct usba_udc *udc;

struct list_head queue;
const struct usb_endpoint_descriptor *desc;

u16 fifo_size;
u8 nr_banks;
Expand Down

0 comments on commit c3d13bd

Please sign in to comment.