Skip to content

Commit

Permalink
[PATCH] uml: tlb flushing fix
Browse files Browse the repository at this point in the history
This patch fixes a fairly serious tlb flushing bug that makes aio use under
uml very unreliable -- SEGVs, Oops and panic()s occur as a result of stale
tlb entires being used by uml when aio switches mms due to the fact that
uml does not implement the activate_mm() hook.  This patch introduces a
simple but correct approach (read: hammer) for implementing activate_mm()
in uml by doing a force_flush_all() if the new mm is different from old.
With this patch in place, uml is able to succeed at the aio test case that
was randomly faulting for me before.

Cc: Jeff Dike <jdike@addtoit.com>
Cc: <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Benjamin LaHaise authored and Linus Torvalds committed Jul 12, 2005
1 parent 8b8a9da commit c40504e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions include/asm-um/mmu_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@

#define deactivate_mm(tsk,mm) do { } while (0)

extern void force_flush_all(void);

static inline void activate_mm(struct mm_struct *old, struct mm_struct *new)
{
if (old != new)
force_flush_all();
}

static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next,
Expand Down

0 comments on commit c40504e

Please sign in to comment.