Skip to content

Commit

Permalink
[libata] Fix section mismatch: ata_sff_exit
Browse files Browse the repository at this point in the history
This build error showed up in linux-next tag next-20100820 for ia64:

WARNING: vmlinux.o(.init.text+0x4a952): Section mismatch in reference from the function ata_init() to the function .exit.text:ata_sff_exit()
The function __init ata_init() references
a function __exit ata_sff_exit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __exit annotation of
ata_sff_exit() so it may be used outside an exit section.

Sure enough, dropping the __exit fixes the problem.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Luck, Tony authored and Jeff Garzik committed Oct 22, 2010
1 parent 6a2148c commit c43d559
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ata/libata-sff.c
Original file line number Diff line number Diff line change
Expand Up @@ -3342,7 +3342,7 @@ int __init ata_sff_init(void)
return 0;
}

void __exit ata_sff_exit(void)
void ata_sff_exit(void)
{
destroy_workqueue(ata_sff_wq);
}

0 comments on commit c43d559

Please sign in to comment.