Skip to content

Commit

Permalink
Revert "Input: atmel_mxt_ts - warn if sysfs could not be created"
Browse files Browse the repository at this point in the history
Dmitry: I understand that I am a bit late to the party :) but I do not
agree with this change. Failure to create attributes is not sometihng
that user could cause (at least not easily) and thus would not be a
setup issue but something more severe. I believe we should fail
loading the driver so sysfs attribute breakage will be noticed as soon
as possible, instead of discovering it much much later in the process.

This reverts commit 6399003.

Requested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
  • Loading branch information
Henrik Rydberg committed Jul 5, 2012
1 parent cab7fac commit c45361a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/input/touchscreen/atmel_mxt_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -1184,10 +1184,13 @@ static int __devinit mxt_probe(struct i2c_client *client,

error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
if (error)
dev_warn(&client->dev, "error creating sysfs entries.\n");
goto err_unregister_device;

return 0;

err_unregister_device:
input_unregister_device(input_dev);
input_dev = NULL;
err_free_irq:
free_irq(client->irq, data);
err_free_object:
Expand Down

0 comments on commit c45361a

Please sign in to comment.